fix: fix type hints for _parse_requirement() #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
bug
jameslamb
changed the title
KyleFromNVIDIA
approved these changes
May 14, 2024
GPUtester
pushed a commit
that referenced
this pull request
May 14, 2024
## [1.13.7](v1.13.6...v1.13.7) (2024-05-14) ### Bug Fixes * fix type hints for _parse_requirement() ([#92](#92)) ([c2ca25a](c2ca25a))
|
🎉 This PR is included in version 1.13.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
difyrrwrzd
added a commit
to difyrrwrzd/dependency-file-generator
that referenced
this pull request
Aug 10, 2024
## [1.13.7](rapidsai/dependency-file-generator@v1.13.6...v1.13.7) (2024-05-14) ### Bug Fixes * fix type hints for _parse_requirement() ([#92](rapidsai/dependency-file-generator#92)) ([5a96946](rapidsai/dependency-file-generator@5a96946))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #87.
Fixes this error from
mypy:_parse_requirement()should never see a dictionary like{"pip": "package"}, because thedependencies.yamlrequires that pip dependencies be an array.dependency-file-generator/src/rapids_dependency_file_generator/schema.json
Lines 154 to 161 in a8660f4
dependency-file-generator/src/rapids_dependency_file_generator/schema.json
Lines 146 to 147 in a8660f4
This fixes a type hint and a test case suggesting that possibility, and adds a new test case to ensure
rapids-dependency-file-generatorrejects lists like this:How I tested this
Saw the new test case I added get picked up in the output of
pytest -v.Saw `rapids-dependency-file-generator raise exactly the expected error on it.
rapids-dependency-file-generator \ --config ./tests/examples/invalid/pip-no-list/dependencies.yaml